noConditionalExpect (JavaScript)

Language JavaScript (and super languages)

Summary

Rule available since: v2.4.2
Diagnostic Category: lint/suspicious/noConditionalExpect
This rule isn’t recommended, so you need to enable it.
This rule doesn’t have a fix.
The default severity of this rule is warning.
This rule belongs to the following domains:
- test
Sources:
- Same as playwright/no-conditional-expect
- Same as jest/no-conditional-expect
- Same as vitest/no-conditional-expect

How to configure

1
{
2
  "linter": {
3
    "rules": {
4
      "suspicious": {
5
        "noConditionalExpect": "error"
6
      }
7
    }
8
  }
9
}

Description

Disallow conditional expect() calls inside tests.

Conditional expectations are problematic because they can silently pass when the condition is false, meaning assertions may never actually run. This can lead to tests that pass despite bugs in the code.

If you need conditional testing logic, consider:

Using test.skip() to skip the entire test
Splitting into separate tests with clear conditions
Using expect.soft() for optional assertions

Examples

Invalid

1
test("conditional expect", async ({ page }) => {
2
    if (someCondition) {
3
        await expect(page).toHaveTitle("Title");
4
    }
5
});

code-block.js:3:15 lint/suspicious/noConditionalExpect ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ⚠ Unexpected conditional expect() call.
  
    1 │ test("conditional expect", async ({ page }) => {
    2 │     if (someCondition) {
  > 3 │         await expect(page).toHaveTitle("Title");
      │               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    4 │     }
    5 │ });
  
  ℹ This expect() is inside a if statement, which means it may not always run.
  
  ℹ Consider using test.skip() to conditionally skip the test, or restructure to avoid conditional expectations.

1
test("ternary expect", async ({ page }) => {
2
    someCondition ? await expect(page).toHaveTitle("Title") : null;
3
});

code-block.js:2:27 lint/suspicious/noConditionalExpect ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ⚠ Unexpected conditional expect() call.
  
    1 │ test("ternary expect", async ({ page }) => {
  > 2 │     someCondition ? await expect(page).toHaveTitle("Title") : null;
      │                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    3 │ });
    4 │ 
  
  ℹ This expect() is inside a ternary expression, which means it may not always run.
  
  ℹ Consider using test.skip() to conditionally skip the test, or restructure to avoid conditional expectations.

1
test("catch expect", async ({ page }) => {
2
    try {
3
        await page.click("button");
4
    } catch (e) {
5
        await expect(page).toHaveTitle("Title");
6
    }
7
});

code-block.js:5:15 lint/suspicious/noConditionalExpect ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ⚠ Unexpected conditional expect() call.
  
    3 │         await page.click("button");
    4 │     } catch (e) {
  > 5 │         await expect(page).toHaveTitle("Title");
      │               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    6 │     }
    7 │ });
  
  ℹ This expect() is inside a catch clause, which means it may not always run.
  
  ℹ Consider using test.skip() to conditionally skip the test, or restructure to avoid conditional expectations.

Valid

1
test("unconditional expect", async ({ page }) => {
2
    await expect(page).toHaveTitle("Title");
3
});

1
test("skip based on condition", async ({ page }) => {
2
    test.skip(someCondition, "Reason to skip");
3
    await expect(page).toHaveTitle("Title");
4
});